fix: HttpRangeReader stall detection, CDN re-resolve, HF API resolve Root cause: 21 GB tensor reads stall silently when HuggingFace CDN drops the TCP connection. curl sits forever with no data. Fixes: - --speed-limit 100000 --speed-time 30: abort if < 100 KB/s for 30s - Re-resolve URL on 403 (CDN token expiry after ~1 hour) - Segment-aligned fetches (no overlapping reads on sequential access) - 6 retries (was 4) with capped exponential backoff (max 32s) - from_hf() constructor: resolves via huggingface_hub Python API first, falls back to curl HEAD, then HF REST API. Stores repo/filename for automatic re-resolution on token expiry. - resolve_hf_url() tries 3 methods: Python HF API → curl HEAD → REST API https://claude.ai/code/session_01HmdXNPit7QsTCfhJFef3Ee#74
Merged
Conversation
The halftone path only sampled 9 of 17 golden-step positions and interpolated the other 8 as neighbor averages. Those 8 bins carried no real signal — dead planes in the projection. Fix: stride octaves (skip every Nth octave) but sample ALL 17 golden-step positions per sampled octave. Every bin gets direct measurement from actual weight values. stride=16, 5120-col row: 19 octaves × 17 positions = 323 samples across all 17 bins (was 171 samples across 9 real + 8 fake bins). https://claude.ai/code/session_01HmdXNPit7QsTCfhJFef3Ee
Root cause: 21 GB tensor reads stall silently when HuggingFace CDN drops the TCP connection. curl sits forever with no data. Fixes: - --speed-limit 100000 --speed-time 30: abort if < 100 KB/s for 30s - Re-resolve URL on 403 (CDN token expiry after ~1 hour) - Segment-aligned fetches (no overlapping reads on sequential access) - 6 retries (was 4) with capped exponential backoff (max 32s) - from_hf() constructor: resolves via huggingface_hub Python API first, falls back to curl HEAD, then HF REST API. Stores repo/filename for automatic re-resolution on token expiry. - resolve_hf_url() tries 3 methods: Python HF API → curl HEAD → REST API https://claude.ai/code/session_01HmdXNPit7QsTCfhJFef3Ee
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AdaWorldAPI
pushed a commit
that referenced
this pull request
Apr 19, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.